Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 28, 2025. It is now read-only.

Conversation

@rumblehhh
Copy link
Contributor

Attempting to use funchook in an Android gradle build results in ninja:
error: 'lib/libcapstone.a', needed by 'xyz.so', missing and no known
rule to make it. Switch out the clunky use of ExternalProject_add for
downloading and building capstone in favour of using it only for
downloading followed by add_subdirectory.

Attempting to use funchook in an Android gradle build results in ninja:
error: 'lib/libcapstone.a', needed by 'xyz.so', missing and no known
rule to make it. Switch out the clunky use of ExternalProject_add for
downloading and building capstone in favour of using it only for
downloading followed by add_subdirectory.
@rumblehhh
Copy link
Contributor Author

Note I'd also be happy to make these changes for zydis if you'd like.
If you were happy to update the minimum CMake version used by funchook to 3.11 I could instead use cmake's FetchContent module. FetchContent internally basically does what I've used in this pull request.
There are some details relating to how/why to use ExternalProject_add as I've done here: https://crascit.com/2015/07/25/cmake-gtest/

@kubo kubo merged commit 7bc6f18 into kubo:master Oct 5, 2021
@kubo
Copy link
Owner

kubo commented Oct 5, 2021

@rumblehhh
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants