feat(dns) internal dns should resolve AAAA records #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past we were sometimes running into issues in dual stack setup because we would only assign a v4 address and only A records would work. Leverage Envoy's :ffff prefix to be able to have AAAA and an A record when using a v4 cidr Signed-off-by: Charly Molter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
==========================================
- Coverage 51.99% 51.96% -0.03%
==========================================
Files 877 877
Lines 51142 51153 +11
==========================================
- Hits 26589 26581 -8
- Misses 22437 22464 +27
+ Partials 2116 2108 -8
Continue to review full report at Codecov.
|
Signed-off-by: Charly Molter <[email protected]>
jakubdyszkiewicz
approved these changes
Sep 13, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
* feat(dns) internal dns should resolve AAAA records In the past we were sometimes running into issues in dual stack setup because we would only assign a v4 address and only A records would work. Leverage Envoy's :ffff prefix to be able to have AAAA and an A record when using a v4 cidr Signed-off-by: Charly Molter <[email protected]> (cherry picked from commit 8be8c35)
lahabana
added a commit
that referenced
this pull request
Sep 13, 2021
* feat(dns) internal dns should resolve AAAA records In the past we were sometimes running into issues in dual stack setup because we would only assign a v4 address and only A records would work. Leverage Envoy's :ffff prefix to be able to have AAAA and an A record when using a v4 cidr Signed-off-by: Charly Molter <[email protected]> (cherry picked from commit 8be8c35) Co-authored-by: Charly Molter <[email protected]>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
* feat(dns) internal dns should resolve AAAA records In the past we were sometimes running into issues in dual stack setup because we would only assign a v4 address and only A records would work. Leverage Envoy's :ffff prefix to be able to have AAAA and an A record when using a v4 cidr Signed-off-by: Charly Molter <[email protected]>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
* feat(dns) internal dns should resolve AAAA records In the past we were sometimes running into issues in dual stack setup because we would only assign a v4 address and only A records would work. Leverage Envoy's :ffff prefix to be able to have AAAA and an A record when using a v4 cidr Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the past we were sometimes running into issues in dual stack setup
because we would only assign a v4 address and only A records would work.
Leverage Envoy's :ffff prefix to be able to have AAAA and an A record
when using a v4 cidr
Full changelog
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.