fix(cxx_extractor): preserve order of exclusive action flags when munging args #5912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than removing and appending, replace the "action" argument with
-fsyntax-onlyto preserve its relative location. There are some flags for which Clang will interpret a subsequent argument which doesn't start with-as an argument to that flag rather than a standalone argument (such as the source file). While removing any argument runs the risk of causing this problem, the source file path generally follows the action argument so we can mitigate this problem by preserving its location when replacing it with-fsyntax-only.It's likely we want to use a smarter mechanism such that when we remove a single
-argument, if the subsequent argument does not start with-it gets moved to the end or something, this should improve the situation for now.