Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ikartiksh
Copy link

Explanation

Added unit test for admission webhook handler.

Related issue

#13872

Milestone of this PR

Documentation (required for features)

My PR contains new or altered behavior to Kyverno.

What type of PR is this

Proposed Changes

Proof Manifests

Test Results in Dev Container

Screenshot 2025-08-20 190506

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Further Comments

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 20, 2025
@ikartiksh ikartiksh marked this pull request as draft August 20, 2025 13:59
@ikartiksh ikartiksh force-pushed the master branch 2 times, most recently from 3061452 to 67b4b9d Compare August 20, 2025 14:22
@ikartiksh ikartiksh marked this pull request as ready for review August 20, 2025 14:23
@dosubot
Copy link

dosubot bot commented Aug 20, 2025

Related Documentation

No published documentation to review for changes on this repository.
Write your first living document

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@lucchmielowski lucchmielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests @ikartiksh 🙏 , LGTM 👍

eddycharly
eddycharly previously approved these changes Aug 27, 2025
@eddycharly eddycharly enabled auto-merge (squash) August 27, 2025 12:03
@fjogeleit
Copy link
Member

@ikartiksh the CLI test is missing, I think you are using a logger package we do not use anywhere else. Can you please check?

@ikartiksh
Copy link
Author

ikartiksh commented Sep 10, 2025

@ikartiksh the CLI test is missing, I think you are using a logger package we do not use anywhere else. Can you please check?

@fjogeleit I don't think we need a CLI test for this PR.
Also Zapr logger was used just for the better observability and structural logging.
May you add something I didn't catchup

@fjogeleit
Copy link
Member

Sorry I did not mean missing, the created Test is failing because you are using a different logger Package which is Not Part of our dependencies

@realshuting
Copy link
Member

Sorry I did not mean missing, the created Test is failing because you are using a different logger Package which is Not Part of our dependencies

Bump.

Signed-off-by: kartiksharma-git <[email protected]>
auto-merge was automatically disabled October 26, 2025 13:59

Head branch was pushed to by a user without write access

@ikartiksh
Copy link
Author

ikartiksh commented Nov 6, 2025

Sorry I did not mean missing, the created Test is failing because you are using a different logger Package which is Not Part of our dependencies

@fjogeleit fixed the logger dependency issue

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.88%. Comparing base (90ce462) to head (25b3a1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13873      +/-   ##
==========================================
+ Coverage   13.85%   13.88%   +0.03%     
==========================================
  Files        1083     1083              
  Lines      104174   104174              
==========================================
+ Hits        14430    14464      +34     
+ Misses      88007    87969      -38     
- Partials     1737     1741       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjogeleit
Copy link
Member

@ikartiksh test lint is failing, looks like an formatting issue. Can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

milestone 1.17.0 size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants