-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test: add unit test for webhooks/handler #13873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3061452 to
67b4b9d
Compare
|
Related Documentation No published documentation to review for changes on this repository. |
lucchmielowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests @ikartiksh 🙏 , LGTM 👍
|
@ikartiksh the CLI test is missing, I think you are using a logger package we do not use anywhere else. Can you please check? |
@fjogeleit I don't think we need a CLI test for this PR. |
|
Sorry I did not mean missing, the created Test is failing because you are using a different logger Package which is Not Part of our dependencies |
Bump. |
Signed-off-by: kartiksharma-git <[email protected]>
Signed-off-by: kartiksharma-git <[email protected]>
Head branch was pushed to by a user without write access
@fjogeleit fixed the logger dependency issue |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13873 +/- ##
==========================================
+ Coverage 13.85% 13.88% +0.03%
==========================================
Files 1083 1083
Lines 104174 104174
==========================================
+ Hits 14430 14464 +34
+ Misses 88007 87969 -38
- Partials 1737 1741 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ikartiksh test lint is failing, looks like an formatting issue. Can you please take a look? |
Explanation
Added unit test for admission webhook handler.
Related issue
#13872
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Test Results in Dev Container
Checklist
Further Comments