enable extending owned resource types in adk translator #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Weiss <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the TranslatorPlugin from a function type to an interface to enable extending owned resource types in the ADK translator. This allows plugins to specify additional Kubernetes resources they own for proper lifecycle management.
- Modified
TranslatorPluginfrom function type to interface with two methods - Updated the
GetOwnedResourceTypes()method to include resources from all plugins - Updated plugin execution to use the new interface method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/pkg/translator/adk_api_translator_types.go | Changed TranslatorPlugin from function type to interface with ProcessAgent and GetOwnedResourceTypes methods |
| go/internal/controller/translator/agent/adk_api_translator.go | Updated to collect owned resources from plugins and call the new interface method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+19
to
+22
| type TranslatorPlugin interface { | ||
| ProcessAgent(ctx context.Context, agent *v1alpha2.Agent, outputs *AgentOutputs) error | ||
| GetOwnedResourceTypes() []client.Object | ||
| } |
There was a problem hiding this comment.
Corrected spelling of 'resoruce' to 'resource' in the PR title.
EItanya
approved these changes
Oct 9, 2025
jmhbh
pushed a commit
to jmhbh/kagent
that referenced
this pull request
Oct 10, 2025
) Signed-off-by: Scott Weiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.