fix(kagent-adk): Fix comment typo for sse tools in types.py #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huang Huang <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a typo in a comment describing the SSE tools loop.
- Corrects comment from "stdio tools" to "sse tools" in types.py
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| tools.append(MCPToolset(connection_params=http_tool.params, tool_filter=http_tool.tools)) | ||
| if self.sse_tools: | ||
| for sse_tool in self.sse_tools: # add stdio tools | ||
| for sse_tool in self.sse_tools: # add sse tools |
There was a problem hiding this comment.
[nitpick] Consider capitalizing the acronym in the comment for clarity and consistency: change 'sse' to 'SSE'.
Suggested change
| for sse_tool in self.sse_tools: # add sse tools | |
| for sse_tool in self.sse_tools: # add SSE tools |
peterj
approved these changes
Oct 20, 2025
EItanya
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.