Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[htmx] basic profile updating #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 4, 2025
Merged

[htmx] basic profile updating #2994

merged 13 commits into from
Jul 4, 2025

Conversation

@ToxicMushroom
Copy link
Collaborator

@ToxicMushroom ToxicMushroom commented Aug 23, 2024 •
edited
Loading

Non access control, non scim version

Fixes part of #2376
Fixes #1688

  • This PR contains no AI generated code
  • book chapter included (if relevant)
  • design document included (if relevant)

Firstyear
Firstyear reviewed Aug 23, 2024
View reviewed changes
@ToxicMushroom ToxicMushroom force-pushed the 20240823-profile-no-acp branch 2 times, most recently from bf780d4 to 28902d5 Compare August 29, 2024 20:45
@johansmitsnl
Copy link

Is this PR gone stale?

@ToxicMushroom
Copy link
Collaborator Author

it is waiting for the scim access control policy feature

@johansmitsnl
Copy link

@ToxicMushroom maybe link the issue for others or did I missed it?

@ToxicMushroom
Copy link
Collaborator Author

It does not look explicitly tracked or mentioned anywhere, maybe @Firstyear considers it part of #211. Or otherwise I can create a new issue for it

@Firstyear
Copy link
Member

Yeah, create a new issue I need to do this sooner than later. I've just been a bit unwell lately sorry

@ToxicMushroom ToxicMushroom mentioned this pull request Dec 30, 2024
Closed
@ToxicMushroom ToxicMushroom force-pushed the 20240823-profile-no-acp branch 2 times, most recently from 72a3a66 to 91307dc Compare February 13, 2025 22:48
@Firstyear
Copy link
Member

@ToxicMushroom I think this is unblocked for you now with the new scim changes.

@ToxicMushroom
Copy link
Collaborator Author

picking this up again sorry for the delay

@ToxicMushroom ToxicMushroom force-pushed the 20240823-profile-no-acp branch from 91307dc to e2c6190 Compare March 6, 2025 01:36
Firstyear
Firstyear reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick play - looks like it needs more work here. I like the unlock feature, maybe it s-hould be a combo "unlock / edit" buton so you have to unlock if you aren't in RW mode, and just gates editing behind some interaction.

Looks like there is no way to save at the end?

Otherwise, good start.

@ToxicMushroom
Copy link
Collaborator Author

So current todo:

  • fixup the diff ui
  • readd legal name ?
  • You said something about account name being of type iname, does scim reflect this, is it just a lowercase string ?

@Firstyear
Copy link
Member

Scim can't reflect it, because it doesn't know the rules, I'll have to think about that some more. We may need to have a way to tag attributes with validators.

@ToxicMushroom
Copy link
Collaborator Author

Scim can't reflect it, because it doesn't know the rules, I'll have to think about that some more. We may need to have a way to tag attributes with validators.

do we just swipe that under the rug for now and add a // TODO: :p I can create an issue for it too ofcourse

@Firstyear
Copy link
Member

Yeah, I think make an issue for it. We need a way to indicate on attributes what validation rules apply.

Also rebase to master :P

@ToxicMushroom ToxicMushroom force-pushed the 20240823-profile-no-acp branch from 26cbb2d to bb0e759 Compare April 5, 2025 10:40
@ToxicMushroom ToxicMushroom mentioned this pull request Apr 5, 2025
Open
@ToxicMushroom ToxicMushroom marked this pull request as ready for review April 6, 2025 02:25
Firstyear
Firstyear requested changes Apr 10, 2025
View reviewed changes
Copy link
Member

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, and I need to get that other PR merged.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to 📋 Backlog in Organising Everything Apr 10, 2025
@Firstyear Firstyear force-pushed the 20240823-profile-no-acp branch from 3077d86 to 526ab2f Compare April 11, 2025 00:02
@Firstyear
Copy link
Member

Looks great! I think it needs a rebase to resolve the conflicts, but then lets give it a go :)

@ToxicMushroom ToxicMushroom force-pushed the 20240823-profile-no-acp branch from e8eb47e to 59e4bdf Compare July 2, 2025 17:18
ToxicMushroom
ToxicMushroom commented Jul 2, 2025
View reviewed changes
@ToxicMushroom ToxicMushroom requested a review from Firstyear July 3, 2025 23:36
@ToxicMushroom
Copy link
Collaborator Author

Shoouuld be good now

@Firstyear Firstyear force-pushed the 20240823-profile-no-acp branch from df75c18 to 9b12dc8 Compare July 4, 2025 03:04
Firstyear
Firstyear previously approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some rough parts, but it works and the edge cases of mail/username with no permission are all handled safely.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🔖 Ready in Organising Everything Jul 4, 2025
@Firstyear Firstyear enabled auto-merge (squash) July 4, 2025 03:07
@Firstyear Firstyear merged commit 1982765 into kanidm:master Jul 4, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Organising Everything Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Firstyear Firstyear Firstyear approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Organising Everything
Status: ✅ Done

Milestone

OpenSUSE Community Requirements

Development

Successfully merging this pull request may close these issues.

WebUI - user management of email addresses

3 participants

@ToxicMushroom @johansmitsnl @Firstyear