Thanks to visit codestin.com
Credit goes to github.com

Skip to content

20250328 41 application passwords + SCIM #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

20250328 41 application passwords + SCIM #3535

merged 2 commits into from
Jun 2, 2025

Conversation

@Firstyear
Copy link
Member

Change summary

  • This is the wrap of ldap application passwords so that they are usable for external applications. And I thought to myself "why not create these with SCIM, it's pretty much ready?". Anyway that turned up a lot of questions and TODO items.

So far this has highlighted a number of shortcomings that need to be resolved. The remaining TODO list is below, and some will be completed in separate PR's

  • Schema needs to change so that Syntax type implies single/multivalue
  • Service Account ACP's interfere with this, so we need to solve how application/oauth/service accounts look as a whole
  • SCIM proto bindings are a bit messy and need a cleanup to better express the client/server relationship, they collide a lot right now
  • Rename of the valueset json_put to drop the _put
  • More that I will surely think of as I go ....

Blocked by

Fixes #41

Checklist

  • This PR contains no AI generated code
  • book chapter included (if relevant)
  • design document included (if relevant)

@Firstyear Firstyear mentioned this pull request Mar 29, 2025
Open
3 tasks
@Firstyear Firstyear mentioned this pull request Apr 10, 2025
Merged
3 tasks
@Firstyear Firstyear force-pushed the 20250328-41-application-passwords branch from da85a84 to 0fe42f6 Compare April 10, 2025 23:35
@Firstyear Firstyear force-pushed the 20250328-41-application-passwords branch from 0fe42f6 to a598ca7 Compare April 26, 2025 03:02
@Firstyear Firstyear marked this pull request as ready for review April 26, 2025 03:02
@Firstyear
Copy link
Member Author

I think the best approach is why this isn't fully completed, what we have works and it's not exposed yet, so I think we merge this and continue to polish as we go.

@Firstyear Firstyear force-pushed the 20250328-41-application-passwords branch from a598ca7 to 8fa4238 Compare May 9, 2025 04:05
@Firstyear Firstyear changed the title 20250328 41 application passwords 20250328 41 application passwords + SCIM May 9, 2025
@Firstyear Firstyear requested a review from yaleman May 9, 2025 04:05
@Firstyear
Copy link
Member Author

@yaleman I would like to get this merged sooner, even though it's work in progress, so that it doesn't grow to be a "giant PR" like other ones have :)

yaleman
yaleman requested changes May 10, 2025
View reviewed changes
Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least one thing's a big red flag "insert" != "replace" and those renames are icky

@github-project-automation github-project-automation bot moved this from 🆕 New to 📋 Backlog in Organising Everything May 10, 2025
yaleman
yaleman previously approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolooooo

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🔖 Ready in Organising Everything May 13, 2025
@Firstyear Firstyear enabled auto-merge (squash) June 1, 2025 15:20
@Firstyear
Start to implement SCIM apis
7813eae 
This adds SCIM api end points, in the hope to complete and
enable these. This uses the application password feature as
a test surface for these api end points.
@Firstyear Firstyear force-pushed the 20250328-41-application-passwords branch from ce11030 to 7813eae Compare June 1, 2025 15:26
@Firstyear
Copy link
Member Author

@yaleman Needs a re-stamp as I did an update/rebase/clippy locally. Nothing really changed though.

@Firstyear Firstyear merged commit 75dd3cc into kanidm:master Jun 2, 2025
23 of 25 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Organising Everything Jun 2, 2025
@Firstyear Firstyear deleted the 20250328-41-application-passwords branch June 2, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaleman yaleman yaleman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Organising Everything
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for API-application passwords

2 participants

@Firstyear @yaleman