Fixing #1353 by filtering the slides in buildOut() #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filter was removed at kenwheeler@9d13d6a#diff-eaaa72f2e5f1d4974e4f1ae902717908L476 for some reason, I cannot figure out why. Since it was removed, filtering slides was not working on initialization. Tested against Init. Tested against setOption. Tested against breakpoints. Fixes kenwheeler#1353
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter was removed at
9d13d6a#diff-eaaa72f2e5f1d4974e4f1ae902717908L476
for some reason, I cannot figure out why. Since it was removed, filtering
slides was not working on initialization.
Tested against Init.
Tested against setOption.
Tested against breakpoints.
Fixes #1353