Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wrong persistent group permissions when multiple group membership changes happen in the same request #44480

@sschu

Description

@sschu

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

core

Describe the bug

When two IDP group mappers assign the same group and one decides to map the group and the other doesnt, there is currently a condition where sometimes the user is in the group and sometimes it is not. This is due to the following change: bb9015a / #43682
Where joinGroup() is missing the condition && updated == null causing it to miss other updates to the user done in the same request.

Version

26.4.5

Regression

  • The issue is a regression

Expected behavior

If two group mappers map the same group and one wants to join and one wants to leave, the join always wins.

Actual behavior

Race condition, sometimes user joins, sometimes he doesn't, depending on mapper execution order.

How to Reproduce?

Skipping as discussed with @ahus1

Anything else?

No response

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions