-
Notifications
You must be signed in to change notification settings - Fork 8k
Description
Description
The comment on the property aligns with the implementation (i.e., configures metadata entry credential_signing_alg_values_supported), but naming it vc.proof_signing_alg_values_supported could mislead into thinking the attribute rather configures metadata entry proof_signing_alg_values_supported. Consider renaming it vc.credential_signing_alg_values_supported for consistency.
keycloak/server-spi-private/src/main/java/org/keycloak/models/oid4vci/CredentialScopeModel.java
Lines 74 to 78 in ae7e7ba
| /** | |
| * if the credential is only meant for specific signing algorithms the global default list can be overridden here. | |
| * The global default list is retrieved from the available keys in the realm. | |
| */ | |
| public static final String SIGNING_ALG_VALUES_SUPPORTED = "vc.proof_signing_alg_values_supported"; |
Make sure that the renaming is well propagated, including affected comments, tests, UI controls, and documentation files.
Also, I think it makes sense to discard symmetric algorithms from the default values of the configuration entry.
Value Proposition
Improves the intelligibility of the configuration attributes.
Goals
- Renaming the attribute
- Improve its default values
Non-Goals
The ticket is not about making it possible to configure proof_signing_alg_values_supported. IMO, we shouldn't bother to.
Discussion
N/A