Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Can we simplify TokenManager.getRefreshExpiration() and TokenManager.getOfflineExpiration()? #20794

@mposolda

Description

@mposolda

Description

Follow-up to PR #17525 :

After the #17525, It seems to me that methods TokenManager.getRefreshExpiration() and TokenManager.getOfflineExpiration() have some duplicated logic for retrieving timeouts. Maybe it's possible to adjust those methods to re-use the logic from SessionExpiration class to have unified place where the logic for timeouts is implemented?

This task is possible refactoring, but it's to be investigated if it makes sense. It seems to me that yes, but I am not yet 100% sure if this would simplify things or rather make them more complicated.

Discussion

No response

Motivation

No response

Details

No response

Metadata

Metadata

Assignees

Labels

area/oidcIndicates an issue on OIDC areakind/enhancementCategorizes a PR related to an enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions