-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Description
Description
It'd be good to increase the test coverage around TLS options for the main HTTP server and for the management HTTP server. For distribution tests, we're using the enableTls toggle, but the setting of TLS is always the same - moving server keystore file to the conf/ directory.
We should more cover explicit seting of these props, such as http-certificate-*, http-key-store-*, http-management-certificate-*, http-management-key-store-*, etc.
It happened once that Quarkus changed some property names and our tests did not expose it in a quick manner. Even some unit tests might be used for the configuration, as we'd also check the config source of the property, which might reveal some useful information.
As @vmuzikar stated (#27629 (comment)):
I wonder if we're missing some integration tests for the TLS options. We're relying on Quarkus in terms of functionality but we don't know if we map the correct options. We'd never know if Quarkus e.g. renamed something. On the other hand it seems we have the same problem with the TLS options for standard HTTP interface.