You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we have AbstractStandardTokenExchangeTest and 2 subclasses of it:
StandardTokenExchangeV1Test for token-exchange V1
StandardTokenExchangeV2Test for token-exchange V2
Once we add more implementations for "Standard token exchange", those tests might differ more and more. So question is, whether to rather make them independent by removing AbstractStandardTokenExchangeTest and copy the tests to both classes?
IMO it seems this might be better to have independent classes as:
The initialization might be different/easier for V2 (For example, there is no need to initialize FGAP as we likely remove them for standard token-exchange V2. Also we can omit initialization of some clients, which are related to "impersonation" test scenarios etc)