-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Closed
Closed
Copy link
Labels
area/corekind/bugCategorizes a PR related to a bugCategorizes a PR related to a bugpriority/importantMust be worked on very soonMust be worked on very soonrelease/26.2.3release/26.3.0team/core-shared
Description
Before reporting an issue
- I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.
Area
core
Describe the bug
When a https url is configured for hostname-admin and requests are http (e.g. from a edge proxy server terminating TLS) requests to /admin/ return a 404.
This was introduced with #38463. The logic comparing requestUrl and adminUrl should be relaxed.
Version
26.2.0
Regression
- The issue is a regression
Expected behavior
Redirect to Admin Console is performed when /admin is accessed via the Admin Hostname - a mismatch in schemes http/https should be allowed.
Actual behavior
404 response when request is http, and hostname-admin is https.
How to Reproduce?
I'm seeing the issue with only the hostname configured - maybe this is internally setting admin to hostname + "/admin"?
./bin/kc.sh start-dev \
--hostname=https://banana.russdev
Access /admin/ with a host header configured - and on http. Observe a 404.
$ curl -v --header 'Host: banana.russdev' localhost:8080/admin/
< HTTP/1.1 404 Not Found
Anything else?
No response
estin68, ZaibanAli, kostik2022, dcoraboeuf and pierrechristinimsa
Metadata
Metadata
Assignees
Labels
area/corekind/bugCategorizes a PR related to a bugCategorizes a PR related to a bugpriority/importantMust be worked on very soonMust be worked on very soonrelease/26.2.3release/26.3.0team/core-shared