Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Mar 28, 2023

This PR continues the work started in #17664

It includes the changes to make Hibernate 6 which was introduces in Quarkus 3.0.0.Alpha6 work with Keycloak.

mabartos and others added 18 commits March 28, 2023 13:48
This reverts commit 2f3fe2b.
This avoids Hibernate 6.2.0.CR4 to fail with 'BasicValue cannot be cast to class ToOne'.
It used to work on Hibernate 6.2.0.CR3.
…o create SAAJ meta-factory: Provider com.sun.xml.messaging.saaj.soap.SAAJMetaFactoryImpl not found" when running SAML.
… this may indicate a semantic (user query) problem or a bug in the parser"

This behavior changed when upgrading from Hibernate 6.2.0.CR3 to 6.2.0.CR4
…ScopeTest".

This behavior changed when upgrading to Hibernate 6
…om VARCHARs

It treated the single byte String with its ASCII values, which then didn't find a representation in the enum's values, which lead to a "ArrayIndexOutOfBoundsException: Index 48" for a value "0" (ASCII 48).
This behavior changed when migrating from Hibernate 5 to Hibernate 6.
Hibernate expects a TinyInt value for all Enums by default, and this annotation overrides it.
@ahus1
Copy link
Contributor Author

ahus1 commented Mar 28, 2023

@sguilhen & @vmuzikar - this PR is now reasonably green, with no failing test that I would attribute to the Hibernate 6 upgrade. I'd be happy if you could give it a review.

There are the following open workarounds which are tracked separately:

@vmuzikar - I added saaj-impl as a dependency to make the SAML tests work.

In the Base test suite part 2, there are two adapter tests failing, which are IMHO unrelated to the Hibernate 6 upgrade:

[ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 75.945 s <<< FAILURE! - in org.keycloak.testsuite.adapter.example.cors.CorsExampleAdapterTest
[ERROR] Tests run: 3, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 44.054 s <<< FAILURE! - in org.keycloak.testsuite.adapter.servlet.DemoFilterServletAdapterTestForCustomizedIdMapper

cc: @vramik, @hmlnarik

@ahus1 ahus1 marked this pull request as ready for review March 28, 2023 15:31
@ahus1 ahus1 requested a review from a team March 28, 2023 15:31
@ahus1 ahus1 requested review from a team as code owners March 28, 2023 15:31
@ahus1 ahus1 requested review from sguilhen and vmuzikar March 28, 2023 15:32
Copy link
Contributor

@sguilhen sguilhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mabartos and @ahus1 . I agree that the failing tests don't seem related to Hibernate 6 upgrade.

Also, as every workaround is being tracked separately - which allows us to remove them once a fix is available in Hibernate - I'm approving this PR.

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both @mabartos and @ahus1, nice work! Changes LGTM, added some questions I'd like to resolve before merge.


<properties>
<resteasy.versions>6.0.0.Final</resteasy.versions>
<resteasy.versions>6.2.3.Final</resteasy.versions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, maybe we could stop overriding it and use the version from the root POM?

<resteasy.version>6.2.2.Final</resteasy.version>

@vmuzikar vmuzikar merged commit 0d96b8d into keycloak:quarkus3 Mar 30, 2023
@ahus1 ahus1 deleted the quarkus3-props branch April 3, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants