Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kg8m/tanshuku
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0
Choose a base ref
...
head repository: kg8m/tanshuku
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.1
Choose a head ref
  • 14 commits
  • 13 files changed
  • 2 contributors

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    7478331 View commit details
    Browse the repository at this point in the history
  2. Use Shields.io

    kg8m authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e8f2c0d View commit details
    Browse the repository at this point in the history
  3. Add badges for Ruby and Rails

    kg8m authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1ee85c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Configuration menu
    Copy the full SHA
    0e294ac View commit details
    Browse the repository at this point in the history
  2. RuboCop: the cop InstanceVariableInClassMethod has been renamed to …

    …`ClassInstanceVariable`
    
    ```
    lib/tanshuku.rb:18:5: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of ThreadSafety/InstanceVariableInClassMethod (did you mean ThreadSafety/ClassInstanceVariable?).
        # rubocop:disable ThreadSafety/InstanceVariableInClassMethod
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    lib/tanshuku.rb:19:5: C: ThreadSafety/ClassInstanceVariable: Avoid class instance variables.
        @config ||= Configuration.new
        ^^^^^^^
    ```
    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    18f9035 View commit details
    Browse the repository at this point in the history
  3. RuboCop: allow the Rake task check:all to generate new threads

    ```
    lib/tasks/check_all.rb:24:32: C: ThreadSafety/NewThread: Avoid starting new threads.
        TASKNAMES.map { |taskname| Thread.new(taskname, &executor) }.each(&:join)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ```
    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    82d1d42 View commit details
    Browse the repository at this point in the history
  4. RuboCop: allow tanshuku.gemspec to change the current directory

    ```
    tanshuku.gemspec:30:5: C: ThreadSafety/DirChdir: Avoid using Dir.chdir due to its process-wide effect.
        Dir.chdir(__dir__) do
        ^^^^^^^^^^^^^^^^^^
    ```
    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e18813c View commit details
    Browse the repository at this point in the history
  5. RuboCop: correct Style/ArrayFirstLast offenses

    ```
    spec/models/tanshuku/url_spec.rb:195:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0]).to be_a ArgumentError
                                      ^^^
    spec/models/tanshuku/url_spec.rb:210:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0]).to be_a ActiveRecord::RecordInvalid
                                      ^^^
    spec/models/tanshuku/url_spec.rb:211:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0].record.errors).to be_of_kind :url, :blank
                                      ^^^
    spec/models/tanshuku/url_spec.rb:226:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0]).to be_a ActiveRecord::RecordInvalid
                                      ^^^
    spec/models/tanshuku/url_spec.rb:227:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0].record.errors).to be_of_kind :url, :invalid
                                      ^^^
    spec/models/tanshuku/url_spec.rb:463:37: C: [Correctable] Style/ArrayFirstLast: Use first.
              expect(reported_exceptions[0]).to be_a ActiveRecord::RecordNotFound
                                        ^^^
    spec/models/tanshuku/url_spec.rb:483:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0]).to be_a ArgumentError
                                      ^^^
    spec/models/tanshuku/url_spec.rb:484:35: C: [Correctable] Style/ArrayFirstLast: Use first.
            expect(reported_exceptions[0].message).to match(/Missing host to link to!/)
                                      ^^^
    ```
    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    ea94bbd View commit details
    Browse the repository at this point in the history
  6. Don’t use splite3 v1.7+

    cf. #331 (comment)
    
    > The CI is failing because [the current version of Rails doesn’t support `sqlite3` v2](https://github.com/rails/rails/blob/v7.1.3.2/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14). We need to wait for the next release of Rails.
    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    d8d4455 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c43215f View commit details
    Browse the repository at this point in the history
  8. v2: support Ruby 3.1

    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    5ccf9c6 View commit details
    Browse the repository at this point in the history
  9. v2: support Rails 7.0 and 7.1

    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3ebd638 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #521 from kg8m/ruby31-and-rails7

    v2: support Ruby 3.1 and Rails 7.0 and 7.1
    kg8m authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    ef7890c View commit details
    Browse the repository at this point in the history
  11. v2.0.1

    kg8m committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    662761b View commit details
    Browse the repository at this point in the history
Loading