-
-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: kg8m/tanshuku
base: v2.0.0
head repository: kg8m/tanshuku
compare: v2.0.1
- 14 commits
- 13 files changed
- 2 contributors
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7478331 - Browse repository at this point
Copy the full SHA 7478331View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f2c0d - Browse repository at this point
Copy the full SHA e8f2c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ee85c3 - Browse repository at this point
Copy the full SHA 1ee85c3View commit details
Commits on Nov 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e294ac - Browse repository at this point
Copy the full SHA 0e294acView commit details -
RuboCop: the cop
InstanceVariableInClassMethodhas been renamed to ……`ClassInstanceVariable` ``` lib/tanshuku.rb:18:5: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of ThreadSafety/InstanceVariableInClassMethod (did you mean ThreadSafety/ClassInstanceVariable?). # rubocop:disable ThreadSafety/InstanceVariableInClassMethod ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/tanshuku.rb:19:5: C: ThreadSafety/ClassInstanceVariable: Avoid class instance variables. @config ||= Configuration.new ^^^^^^^ ```Configuration menu - View commit details
-
Copy full SHA for 18f9035 - Browse repository at this point
Copy the full SHA 18f9035View commit details -
RuboCop: allow the Rake task
check:allto generate new threads``` lib/tasks/check_all.rb:24:32: C: ThreadSafety/NewThread: Avoid starting new threads. TASKNAMES.map { |taskname| Thread.new(taskname, &executor) }.each(&:join) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```Configuration menu - View commit details
-
Copy full SHA for 82d1d42 - Browse repository at this point
Copy the full SHA 82d1d42View commit details -
RuboCop: allow
tanshuku.gemspecto change the current directory``` tanshuku.gemspec:30:5: C: ThreadSafety/DirChdir: Avoid using Dir.chdir due to its process-wide effect. Dir.chdir(__dir__) do ^^^^^^^^^^^^^^^^^^ ```Configuration menu - View commit details
-
Copy full SHA for e18813c - Browse repository at this point
Copy the full SHA e18813cView commit details -
RuboCop: correct Style/ArrayFirstLast offenses
``` spec/models/tanshuku/url_spec.rb:195:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0]).to be_a ArgumentError ^^^ spec/models/tanshuku/url_spec.rb:210:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0]).to be_a ActiveRecord::RecordInvalid ^^^ spec/models/tanshuku/url_spec.rb:211:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0].record.errors).to be_of_kind :url, :blank ^^^ spec/models/tanshuku/url_spec.rb:226:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0]).to be_a ActiveRecord::RecordInvalid ^^^ spec/models/tanshuku/url_spec.rb:227:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0].record.errors).to be_of_kind :url, :invalid ^^^ spec/models/tanshuku/url_spec.rb:463:37: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0]).to be_a ActiveRecord::RecordNotFound ^^^ spec/models/tanshuku/url_spec.rb:483:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0]).to be_a ArgumentError ^^^ spec/models/tanshuku/url_spec.rb:484:35: C: [Correctable] Style/ArrayFirstLast: Use first. expect(reported_exceptions[0].message).to match(/Missing host to link to!/) ^^^ ```Configuration menu - View commit details
-
Copy full SHA for ea94bbd - Browse repository at this point
Copy the full SHA ea94bbdView commit details -
cf. #331 (comment) > The CI is failing because [the current version of Rails doesn’t support `sqlite3` v2](https://github.com/rails/rails/blob/v7.1.3.2/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14). We need to wait for the next release of Rails.
Configuration menu - View commit details
-
Copy full SHA for d8d4455 - Browse repository at this point
Copy the full SHA d8d4455View commit details -
Configuration menu - View commit details
-
Copy full SHA for c43215f - Browse repository at this point
Copy the full SHA c43215fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ccf9c6 - Browse repository at this point
Copy the full SHA 5ccf9c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ebd638 - Browse repository at this point
Copy the full SHA 3ebd638View commit details -
Merge pull request #521 from kg8m/ruby31-and-rails7
v2: support Ruby 3.1 and Rails 7.0 and 7.1
Configuration menu - View commit details
-
Copy full SHA for ef7890c - Browse repository at this point
Copy the full SHA ef7890cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 662761b - Browse repository at this point
Copy the full SHA 662761bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.0...v2.0.1