-
Notifications
You must be signed in to change notification settings - Fork 530
Open
Labels
enhancementThis is the preferred way to describe new end-to-end features.This is the preferred way to describe new end-to-end features.refinementStill being full defined before taking any actionStill being full defined before taking any action
Description
What do you want to improve?
I want to do go install github.com/kiali/kiali as an alternative to downloading a pre-built binary. This would allow users on MacOS and Windows to run Kiali locally without needing to published signed binaries for those platforms.
Barriers to this:
- replace directive in go.mod
go installdoes not supportreplacedirectives. Looking atgo.sum, none of the Kiali dependencies use this dep anymore so it can be removed. go installwould not include the UI.
The UI dir is included when the backend is built. Probably this would be missing when you dogo installsince the production build of the UI assets is not checked in to git.- Kiali versioning does not match go versioning.
Kiali released version 2.x of Kiali but did not follow the go versioning strategy. See this issue for more details. A workaround is to install from a specific commit or branchgo install github.com/kiali/kiali@masterbut the above two issues would need to be fixed first.
What is the current behavior?
go install github.com/kiali/kiali@master does not work.
What is the new behavior?
go install github.com/kiali/kiali@master works.
Metadata
Metadata
Assignees
Labels
enhancementThis is the preferred way to describe new end-to-end features.This is the preferred way to describe new end-to-end features.refinementStill being full defined before taking any actionStill being full defined before taking any action