Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SMODS.has_no_suit() and SMODS.has_any_suit support #5

@blazingulag

Description

@blazingulag

Not a big issue at all, but something to improve compatibility with other mods.

In the Card:is_suit() hook, the line if self.ability.effect == 'Stone Card' or self.config.center.no_suit then should use SMODS.has_no_suit() instead for better mod compatibility. Less important, but if (self.ability.name == 'Wild Card' or self.config.center.any_suit) and not self.debuff then could use SMODS.has_any_suit for the same reason.

Right now this only works with enhancements that make a card have no suit, not other effect that do so, like from jokers.
Sorry if there's a specific reason this method wasn't used and i missed that.

As i said, not a big deal but I hope this gets changed, especially because it's a very easy fix

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions