-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Hi there,
We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
The issue is described in tidyverse/ggplot2#6498, where you're welcome to raise discussion.
The issue isn't with your packaged code, but with these expectations:
LSX/tests/testthat/test-textplot.R
Lines 12 to 30 in 6e4b64f
| suppressWarnings({ | |
| expect_equal(class(textplot_simil(lss)), c("gg", "ggplot")) | |
| }) | |
| expect_equal(class(textplot_terms(lss, highlighted = dict$keywords)), | |
| c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, highlighted = dict$keywords, max_words = 2)), | |
| c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, highlighted = dict$keywords, max_highlighted = 10)), | |
| c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, highlighted = dict$keywords, max_highlighted = 0)), | |
| c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, highlighted = dict)), | |
| c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, highlighted = character())), | |
| c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss)), c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, max_highlighted = 10)), c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, sampling = "relative")), c("gg", "ggplot")) | |
| expect_equal(class(textplot_terms(lss, sampling = "absolute")), c("gg", "ggplot")) |
And similar expectation elsewheres. You can test your code with the development version of ggplot2 by installing it as follows:
# install.packages("pak")
pak::pak("tidyverse/ggplot2")We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time. Hopefully this will inform you in a timely manner.
Best wishes,
Teun
Metadata
Metadata
Assignees
Labels
No labels