Improved Type Safety in Python Client API #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
awesome :) could you fix the failing unit tests? otherwise looks good! |
Author
|
thanks @codekansas . I just fixed the failing unit tests and pushed it. |
WT-MM
reviewed
Jan 21, 2025
Contributor
WT-MM
left a comment
There was a problem hiding this comment.
Awesome, this looks really good! Just a few nitpicks to satisfy my ocd
Author
|
@WT-MM Hope this helps :) |
Contributor
|
okay, actually after taking another look at this again, can we keep the protobuf return types if they're typed or use dataclasses? Being able to access values as attributes is probably more ergonomic (e.g. getting Otherwise, it's probably ready to merge in - I'll resolve conflicts and merge in afterwards |
Author
|
@WT-MM you are right. Having access to the values as attributes is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the type safety of the Python client API by ensuring consistent TypedDict usage across all service clients. This makes the API more predictable.
Changes
Testing
make formatfor code formattingruffmake testto verify functionalityRelated Issues
Closes #32