✨ Banner which tells you can update to latest ksctl release #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a notification banner prompting users to update to the latest ksctl release. It updates logger formatting, implements an update cache mechanism, and integrates update checking and notification into the commands.
- Updated logger formatting to center align titles and content.
- Added a new update cache to track update checks.
- Integrated update checking and notification into the CLI commands.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/logger/general_logging.go | Adjusted styling and alignment of the logging output. |
| pkg/config/cache.go | Added update cache logic to persist update check information. |
| cmd/update.go | Introduced update check and notification on self-update commands. |
| cmd/root.go | Integrated update checking in the root command initialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Changelog
🔍 Review Checklist
📸 Screenshots/Recordings
📌 Additional Notes
💡 PR best practices
pre-commitfor that run this command$ pre-commit install