Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Maintenance] Fix docker images by pinning ray==2.3.1, daft==0.1.20, unpinning proto, and using torch 2.1.1. #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2024
Merged

[Maintenance] Fix docker images by pinning ray==2.3.1, daft==0.1.20, unpinning proto, and using torch 2.1.1. #3872

merged 3 commits into from
Jan 10, 2024

Conversation

@justinxzhao
Copy link
Contributor

No description provided.

@justinxzhao justinxzhao marked this pull request as draft January 10, 2024 07:17
@github-actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Unit Test Results

  6 files  ±0    6 suites  ±0   14m 5s ⏱️ -12s
12 tests ±0    9 ✔️ ±0    3 💤 ±0  0 ❌ ±0 
60 runs  ±0  42 ✔️ ±0  18 💤 ±0  0 ❌ ±0 

Results for commit dec8fe2. ± Comparison against base commit b0d11a0.

♻️ This comment has been updated with latest results.

@arnavgarg1
Copy link
Contributor

Nice @justinxzhao! Looks like most of this is passing - we may need to just be less strict with the minimum Ray version. I'm currently trying to build an image with it - if it works, I can push that change up!

@justinxzhao justinxzhao changed the title Attempt: Fix docker images by pinning ray, daft, unpinning proto, and using torch 2.1.1. [MAINTENANCE] Fix docker images by pinning ray==2.3.1, daft==0.1.20, unpinning proto, and using torch 2.1.1. Jan 10, 2024
@justinxzhao justinxzhao marked this pull request as ready for review January 10, 2024 17:44
@justinxzhao justinxzhao changed the title [MAINTENANCE] Fix docker images by pinning ray==2.3.1, daft==0.1.20, unpinning proto, and using torch 2.1.1. [Maintenance] Fix docker images by pinning ray==2.3.1, daft==0.1.20, unpinning proto, and using torch 2.1.1. Jan 10, 2024
arnavgarg1
arnavgarg1 reviewed Jan 10, 2024
View reviewed changes
arnavgarg1
arnavgarg1 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the fix! I think it should be fine to use Ray 2.3.1 for our entire testing suite given that there are many newer Ray releases and we are pretty far behind.

@justinxzhao justinxzhao merged commit b6b1f70 into master Jan 10, 2024
@justinxzhao justinxzhao deleted the docker_fix branch January 10, 2024 19:43
vijayi1 pushed a commit to vijayi1/ludwig that referenced this pull request Jan 23, 2024
@justinxzhao @vijayi1
[Maintenance] Fix docker images by pinning ray==2.3.1, daft==0.1.20, …
dc53cfd 
…unpinning proto, and using torch 2.1.1. (ludwig-ai#3872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@w4nderlust w4nderlust Awaiting requested review from w4nderlust w4nderlust is a code owner

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus is a code owner

@jeffkinnison jeffkinnison Awaiting requested review from jeffkinnison jeffkinnison is a code owner

@Infernaught Infernaught Awaiting requested review from Infernaught Infernaught is a code owner

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky alexsherstinsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinxzhao @arnavgarg1