fix: devtool instance registration for ios android #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| val devServerHost = project.findProperty("DEV_SERVER_HOST") as String? ?: "10.0.2.2" |
There was a problem hiding this comment.
should we also do DEV_SERVER_PORT?
| // Register new modules with: | ||
| // config.register(YourModuleName.self) | ||
|
|
||
| lynxEnv.lynxDebugEnabled = true |
There was a problem hiding this comment.
let's to it only for dev
#if DEBUG
// Your debug-only code here
#endif
| @@ -0,0 +1,87 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
not sure if we should land it, we can but this will super temporary and tbh I would just properly implement run:android and run:ios commands
| @@ -1,40 +1,42 @@ | |||
| { | |||
There was a problem hiding this comment.
why this change? is it compatible with the current linter config? btw we should add lint and type checks to the CI pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the app were installing devtool package and config but were not enabled in the service instance.
this enables them so that we can use lynx devtool with create-lynxjs-app.