Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[REQUEST] ABI compatibility with Rofi? #96

@SabrinaJewson

Description

@SabrinaJewson

Before opening a feature request

  • I checked the next branch to see if the feature has already been implemented
  • I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

Plugins built for normal Rofi are currently ABI-incompatible with plugins built for this (Wayland) Rofi; however, this is not made obvious to the user (attempting to load a Rofi plugin using Wayland Rofi simply results in UB, manifesting as an unhelpful assertion failure), nor is it easy for plugin authors to support both normal and Wayland Rofi.

I would suggest one of two things:

  1. undo the breaking changes made to Rofi’s plugin ABI (most importantly, the extra parameter in _mode_get_icon, but rofi_icon_fetcher_query[_advanced] may also be changed), or if that is not possible
  2. bump the ABI version number from 7 to something like 1007, to ensure that the error is made obvious to the user.

How do you know that this problem exists today? Why is this important?

Some people use Wayland Rofi for practical use, as it is in the AUR.

My interest in this comes from wanting to support Wayland Rofi in my Rust library for writing Rofi plugins: SabrinaJewson/rofi-mode.rs#8.

Who will benefit from it?

People who write and use plugins for Wayland Rofi.

Rofi version (rofi -v)

Latest commit from repositories, as of 2023-10-31

Configuration

N/A

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions