Add total_records fields for players and federations endpoint #293
Conversation
df88d61 to
7cc08f7
Compare
modules/db/src/main/scala/Db.scala
Outdated
| postgres.use(_.execute(q)(f.argument)) | ||
|
|
||
| def countFederationsSummary: IO[Long] = | ||
| import skunk.implicits.* |
There was a problem hiding this comment.
Is it okay to introduce dependency on skunk here? Seems sql macros belongs to Sql object, but otherwise I just would import it on top of the Db object declaration
There was a problem hiding this comment.
yeah you're right, I was just lazy 😂. Moved sql stuff to Sql object.
7cc08f7 to
2959718
Compare
Masynchin
left a comment
There was a problem hiding this comment.
Looks cheesy for me 👍🏻
|
@lenguyenthanh this two queries instantiates two connections, rather than using one, is it acceptable? In case of no, it can be added new layer, which combines query functions of |
|
yeah, It would be ideal if it uses only one connection. Another think we could do to optimize this is cache the count query instead of executing it for every page. |
I don't see how this cache can be properly invalidated 🤔 |
We can use crawler to invalidate the cache 🤔 or just use some arbitrary ttl. |
Seems workable. My concern is about consistency, so TTL seems disastrous 😁 |
yeah, if we're worry about consistency then ttl is tragic, we probably not too worry about it tho 😛. But using crawler to invalidate the cache is much better idea anyway. |
Fix #280