Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix errors in Makefile #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Fix errors in Makefile #4865

merged 1 commit into from
May 22, 2025

Conversation

@rucoder
Copy link
Contributor

@rucoder rucoder commented May 22, 2025 •
edited by eriknordmark
Loading

Description

  • Move PLATFORM definition to main Makefile and define it before it is used. Currently TARGPLAT was never set to empty string
  • Use $(first-word) to get only the first modifier for platfroms like nvidia-jp5. The second file images/modifiers/jp5.yq is ignored by tools/compose-image-yml.sh but it is not expected to be passed at all

PR dependencies

How to test and validate this PR

build all platforms and validate they are built properly

PR Backports

  • 14.5-stable
  • 13.4-stable
  • 12.0-stable

Checklist

  • I've provided a proper description
  • I've added the proper documentation (when applicable)
  • I've tested my PR on amd64 device(s)
  • I've tested my PR on arm64 device(s)
  • I've written the test verification instructions
  • I've set the proper labels to this PR

@rucoder rucoder requested a review from eriknordmark as a code owner May 22, 2025 13:51
@OhmSpectator OhmSpectator added the stable Should be backported to stable release(s) label May 22, 2025
@rucoder
Fix errors in Makefile
1f78fdb 
- Move PLATFORM definition to main Makefile and define it bofor it is
  used. Currently TARGPLAT was never set to empty string
- Use $(first-word) to get only the first modifier for platforms like
  nvidia-jp5. The second file images/modifiers/jp5.yq is ignored by
  tools/compose-image-yml.sh but it is not expected to be passed at all

Signed-off-by: Mikhail Malyshev <[email protected]>
@rucoder rucoder force-pushed the rucoder/makefile-fix branch from 51c385d to 1f78fdb Compare May 22, 2025 14:09
rene
rene approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OhmSpectator
OhmSpectator approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rucoder explained it to me directly. Looks good.

@eriknordmark eriknordmark merged commit 02784a5 into lf-edge:master May 22, 2025
45 of 50 checks passed
This was referenced Jul 9, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rene rene rene approved these changes

@eriknordmark eriknordmark Awaiting requested review from eriknordmark eriknordmark is a code owner

@christoph-zededa christoph-zededa Awaiting requested review from christoph-zededa

+1 more reviewer

@OhmSpectator OhmSpectator OhmSpectator approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stable Should be backported to stable release(s)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rucoder @rene @OhmSpectator @eriknordmark