Fix segfault when coverage simplify called with nonpolygons #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {} | ||
| { | ||
| for (const Geometry* g: m_input) { | ||
| if (!g->isPolygonal()) |
There was a problem hiding this comment.
I think isPolygonal can return true for GeometryCollections that contain polygons. But the simplifier code will still segfault for this as well (noticed while implementing the bindings in shapely in shapely/shapely#2241).
Using geosop:
# GeometryCollection of polygons -> fine
$ geosop -a "GEOMETRYCOLLECTION (POLYGON ((0 10, 10 10, 10 7, 10 3, 10 0, 0 0, 0 10)), POLYGON ((10 10, 20 10, 20 0, 10 0, 10 3, 10 7, 10 10)))" coverageSimplify 1.0
POLYGON ((10 10, 10 0, 0 0, 0 10, 10 10))
POLYGON ((10 10, 20 10, 20 0, 10 0, 10 10))
# GeometryCollection of polygon and collection -> segfaults
$ geosop -a "GEOMETRYCOLLECTION (POLYGON ((0 10, 10 10, 10 7, 10 3, 10 0, 0 0, 0 10)), GEOMETRYCOLLECTION (POLYGON ((10 10, 20 10, 20 0, 10 0, 10 3, 10 7, 10 10))))" coverageSimplify 1.0
Segmentation fault (core dumped)(and using a nested GeometryCollection here because we first collect the array of input geometries (which can contain a collection) in a collection)
There was a problem hiding this comment.
Opened a new issue to track this -> #1250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References GH-1031