Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ZeRego
Copy link
Collaborator

@ZeRego ZeRego commented May 23, 2025

Related to: #14969

Description:

Allow filter input components to be rendered without a field.

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@owlas owlas deployed to 05-22-chore_optional_field_in_filter_inputs - jaffle_db_pg_13 PR #14966 May 23, 2025 08:06 — with Render Active
@owlas owlas deployed to 05-22-chore_optional_field_in_filter_inputs - headless-browser PR #14966 May 23, 2025 08:06 — with Render Active
@ZeRego ZeRego force-pushed the 05-22-chore_optional_field_in_filter_inputs branch from f23d3e9 to 6d9ed85 Compare May 23, 2025 13:55
@owlas owlas temporarily deployed to 05-22-chore_optional_field_in_filter_inputs - lightdash PR #14966 May 23, 2025 13:55 — with Render Destroyed
@owlas owlas temporarily deployed to 05-22-chore_optional_field_in_filter_inputs - headless-browser PR #14966 May 23, 2025 13:55 — with Render Destroyed
Copy link
Contributor

@pimmey pimmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeRego ZeRego merged commit a236de5 into main May 23, 2025
45 of 48 checks passed
@ZeRego ZeRego deleted the 05-22-chore_optional_field_in_filter_inputs branch May 23, 2025 15:53
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1648.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants