chore: update SQL chart column metadata to include type information #14983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2025
This was referenced May 23, 2025
Merged
ZeRego
force-pushed
the
05-22-chore_optional_field_in_getfilterrulewithdefaultvalue
branch
from
26fba7a to
715f7eb
Compare
ZeRego
force-pushed
the
05-23-chore_store_sql_column_type_in_dashboard_context
branch
from
78410c9 to
499bfb0
Compare
3 tasks
ZeRego
changed the title
pimmey
approved these changes
May 23, 2025
ZeRego
force-pushed
the
05-23-chore_store_sql_column_type_in_dashboard_context
branch
from
499bfb0 to
b868221
Compare
ZeRego
force-pushed
the
05-22-chore_optional_field_in_getfilterrulewithdefaultvalue
branch
from
715f7eb to
a2c5c1c
Compare
ZeRego
force-pushed
the
05-23-chore_store_sql_column_type_in_dashboard_context
branch
from
b868221 to
ef368be
Compare
ZeRego
force-pushed
the
05-22-chore_optional_field_in_getfilterrulewithdefaultvalue
branch
from
a2c5c1c to
8677db3
Compare
ZeRego
force-pushed
the
05-22-chore_optional_field_in_getfilterrulewithdefaultvalue
branch
from
8677db3 to
b499a5f
Compare
ZeRego
force-pushed
the
05-23-chore_store_sql_column_type_in_dashboard_context
branch
from
ef368be to
afd6514
Compare
Base automatically changed from
05-22-chore_optional_field_in_getfilterrulewithdefaultvalue
to
main
May 24, 2025 07:46
|
🎉 This PR is included in version 0.1650.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #14969
Description:
This PR updates the SQL chart tile metadata to include column type information. Previously, only column references were stored, but now we're storing both the reference and type for each column. This change ensures that dashboard filters have access to the correct column type information when configuring filters.
Key changes:
SqlChartTileMetadatatype to storeResultColumnobjects (with reference and type) instead of just stringsDashboardSqlChartTileto extract both reference and type from query dimensionsReviewer actions