refactor: extract getFilterTypeFromItemType function #14985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2025
Merged
3 tasks
ZeRego
force-pushed
the
refactor_rename_getConditionalRuleLabel_to_getConditionalRuleLabelFromItem_and_add_tests
branch
from
9e6040b to
25f476e
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
5c1024b to
06c0f19
Compare
3 tasks
pimmey
approved these changes
May 23, 2025
ZeRego
force-pushed
the
refactor_rename_getConditionalRuleLabel_to_getConditionalRuleLabelFromItem_and_add_tests
branch
from
25f476e to
12f72c8
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
06c0f19 to
5e2ca4f
Compare
ZeRego
force-pushed
the
refactor_rename_getConditionalRuleLabel_to_getConditionalRuleLabelFromItem_and_add_tests
branch
from
12f72c8 to
b543a31
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
2 times, most recently
from
6ae17d0 to
d4aaf23
Compare
ZeRego
force-pushed
the
refactor_rename_getConditionalRuleLabel_to_getConditionalRuleLabelFromItem_and_add_tests
branch
2 times, most recently
from
f506024 to
63b5df3
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
d4aaf23 to
79ea36e
Compare
Base automatically changed from
refactor_rename_getConditionalRuleLabel_to_getConditionalRuleLabelFromItem_and_add_tests
to
main
May 24, 2025 08:04
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
79ea36e to
6ad247d
Compare
|
🎉 This PR is included in version 0.1650.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #14969
Description:
Refactored filter type determination by extracting a new utility function
getFilterTypeFromItemTypethat accepts a dimension, metric, or table calculation type directly. This allows for more flexibility when determining filter types without needing the full item object.The original
getFilterTypeFromItemfunction now uses this new utility function internally, maintaining backward compatibility while enabling more granular filter type determination.Reviewer actions