Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add configurable repl options #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2018
Merged

Add configurable repl options #333

merged 1 commit into from
May 18, 2018

Conversation

@narma
Copy link
Contributor

@narma narma commented May 17, 2018 •
edited
Loading

Related to #301

It simplify use case described in this issue #301
instead of overriding whole repl function
you just need override one replOptions on your choice.

@lihaoyi
Copy link
Member

lihaoyi commented May 18, 2018

Could we instead make the repl command take the replOptions: String* as varargs? That way people can manually pass in whatever replOptions they want directly from the command line, and people would still be able to override def repl(replOptions: String*) = super.repl(Seq("foo", "bar", "baz")) if they wanted to override it in the build file

@narma narma force-pushed the easy-mill-repl-options branch from 529ae2b to bb6d8b0 Compare May 18, 2018 09:54
@narma
Copy link
Contributor Author

narma commented May 18, 2018

@lihaoyi 👍 just updated PR according your suggestion

@lihaoyi lihaoyi merged commit aba5be9 into com-lihaoyi:master May 18, 2018
@narma narma deleted the easy-mill-repl-options branch May 19, 2018 03:34
@lefou lefou added this to the 0.2.1 milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@narma @lihaoyi @lefou