fix: unambiguously refer to ArgoCD apps #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasLubbers
approved these changes
Sep 4, 2025
Ani1357
approved these changes
Sep 5, 2025
Ani1357
pushed a commit
that referenced
this pull request
Sep 5, 2025
Co-authored-by: svcAPLBot <[email protected]> (cherry picked from commit a493555)
Ani1357
pushed a commit
that referenced
this pull request
Sep 12, 2025
Co-authored-by: svcAPLBot <[email protected]> (cherry picked from commit a493555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR updates
kubectlcommands to always refer to the ArgoCD "Application" resource. Also it checks on installed ArgoCD apps beforehand, suppressing messages likeError from server (NotFound): applications.argoproj.io "<app-name>" not foundon every operator run.🔍 Reviewer Notes
🧹 Checklist