fix: smoke tests should fail on template rendering failure #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merll
reviewed
Aug 7, 2025
merll
reviewed
Aug 7, 2025
merll
approved these changes
Aug 7, 2025
CasLubbers
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR fixes that when template rendering fails that the pipeline fails instead of just passing.
🔍 Reviewer Notes
Create a branch from this branch and
git push --no-verifywith a broken templateOR
Update a gotmpl in values to break.
run docker build for both apl-tools and apl-core. You might need to change the location/name and version of the image in the apl-core docker file on line 1 and line 39.