Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@merll
Copy link
Contributor

@merll merll commented Oct 6, 2025

πŸ“Œ Summary

This PR implements small changes in the installation process to make it more robust against temporary failure and race conditions:

  • Final steps after the main installation are retried with more focus on the failing command, whereas before it would have reattempted the entire installation: Final commit to the values repo, cloning of the Chart repo, creating the initial admin secret, restarting API.
  • If the initial admin secret exists, it is patched instead of failing the installation.
  • APL Operator is no longer installed together with all other apps, because its actions could in rare circumstances conflict with the installer that has not finished. Also it creates network policies, that do not consider the installer which needs access to certain resources. APL Operator is installed after all other apps, the installation is also reattempted on failure separately.
  • On retrying the entire installation, the delay is now fixed to 30 seconds, whereas before it would make the first reattempt after one second. 30 seconds may give a failed Helm install more time to perform a rollback.
  • e2e elements have been removed from the install as they were not used but triggered unnecessary Kubernetes API calls. They could still be applied using the otomi apply-e2e command if ever needed.

πŸ” Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@merll merll marked this pull request as ready for review October 7, 2025 09:31
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but they're not blocking. Tested with a cluster πŸ‘πŸ» LGTM

@merll merll merged commit b368695 into main Oct 14, 2025
12 checks passed
@merll merll deleted the APL-1181-2 branch October 14, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants