This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Make the namerd stream resilient to failures #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the semantics of `futures::Stream` changed such that errors are terminal. Now, we ensure that individual namerd request failures are not propagated onto the admin stream. Furthermore, configuration files have been made more brittle so that unknown fields are not silently ignored.
stevej
reviewed
Mar 22, 2017
src/namerd.rs
Outdated
| match *rsp.status() { | ||
| StatusCode::Ok => parse_body(rsp.body()), | ||
| status => { | ||
| trace!("namerd error: {}", status); |
stevej
approved these changes
Mar 22, 2017
olix0r
added a commit
that referenced
this pull request
Mar 22, 2017
Recently the semantics of `futures::Stream` changed such that errors are terminal. Now, we ensure that individual namerd request failures are not propagated onto the address stream. Furthermore, configuration files have been made more brittle so that unknown fields are not silently ignored.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Recently the semantics of
futures::Streamchanged such that errors areterminal.
Now, we ensure that individual namerd request failures are not propagated onto
the namer stream.
Furthermore, configuration files have been made more brittle so that unknown
fields are not silently ignored.