Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[IPAM] Major refactoring #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Dec 18, 2024
Merged

[IPAM] Major refactoring #2852

merged 32 commits into from
Dec 18, 2024

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented Dec 6, 2024 •
edited
Loading

Description

This PR includes a major refactoring of the liqo IPAM module.

The IPAM is a component that manages IPs and networks, allocating them from pre-defined pools.

Goals

The IPAM has two jobs:

  • reserve/release a provided network. If it is already used, allocate and reserve a new one with the same prefix length.
  • reserve/release an IP from a given network CIDR.

Architecture

image-2024-10-28_17-16-27

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Dec 6, 2024

/test

@cheina97 cheina97 changed the title New Ipam module [IPAM] New Ipam module Dec 10, 2024
@cheina97 cheina97 changed the title [IPAM] New Ipam module [IPAM] Major refactoring Dec 10, 2024
fra98 and others added 24 commits December 17, 2024 10:58
@fra98
chore: bump protoc binaries and grpc lib
1532a2b
@aleoli @fra98
ipam api and first stub
8b1381e
@aleoli @fra98
initialize ipam
8ce5366
@fra98
feat: IP API specify optional CIDR to acquire IP from
cfb9a87
@fra98
perf: avoid passing IP to IPAcquire() gRPC func
c71e6b9
@fra98
fix: ipam rbacs and flags
09881ce
@fra98
fix: expose gRPC methods on server
85c4f54
@fra98
feat: ipam sync routine
bf71be0
@fra98
test: ipam sync routine unit tests
2f5ec0d
@fra98
refactor: updated Configuration controller for new Ipam
e15df52
@fra98
refactor: updated Network controller for new ipam
fee1b3b
@fra98
feat: implemented frontend ipam client functions
4fef5fd
@fra98
fix: removed redundant ResponseResult return value on grpc
5af097c
@fra98
refactor: updated IP controller for new ipam
a1cddfe
@fra98
refactor: avoid importing nftables to get first IP
3a3fbc5
@aleoli @fra98
ipam: cleanup old packages and resources
afe16b8
@fra98
fix: wait for ipam grpc server to be Ready
cd20e77
@fra98
feature: reserve n IPs on Networks
7b5ba6d
@fra98
feature: ipam support reserved networks
0b10dc8
@cheina97 @fra98
feat: ipam core
7b33e1b
@cheina97 @fra98
ci: ipam branch build
cf0633b
@fra98
feat: ipam support additional pools
9bba616
@fra98
fix: ipam uninstall
b4bfd07
@aleoli @fra98
ipam: fix ha
901d24f
@fra98 fra98 marked this pull request as ready for review December 17, 2024 10:14
@fra98
Copy link
Member Author

fra98 commented Dec 17, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Dec 18, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 18, 2024
@adamjensenbot adamjensenbot merged commit bf0d37b into master Dec 18, 2024
37 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 18, 2024
@adamjensenbot adamjensenbot deleted the ipam branch December 18, 2024 08:47
@fra98 fra98 mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheina97 cheina97 cheina97 approved these changes

@aleoli aleoli aleoli approved these changes

@claudiolor claudiolor Awaiting requested review from claudiolor

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fra98 @adamjensenbot @cheina97 @aleoli