Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/task] Improve ergonomics of taskComplete promise #2347

@sorvell

Description

@sorvell

There are a few issues with the taskComplete promise.

  • It's marked with ! on the class, but it's only created when the task runs.
  • If a user accesses it before the task runs for example when the Task is created, there's an error.
  • If a user accesses it for a manually run task, autoRun set to false, there's an error.

Perhaps it can just be initialized when the Task is created?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions