Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: requests error handling #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkhokhlov merged 11 commits into from
May 10, 2022
Merged

fix: requests error handling #82

dkhokhlov merged 11 commits into from
May 10, 2022

Conversation

@dkhokhlov
Copy link
Contributor

@dkhokhlov dkhokhlov commented May 3, 2022 •
edited
Loading

  • added locally built docker build-image
  • fixed retries for 5xx errors
  • fixed various leftover build issues

LOG-11814

@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch 5 times, most recently from c16f660 to bb91457 Compare May 4, 2022 02:37
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch from bb91457 to 83a68bf Compare May 4, 2022 02:42
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch from a4590a8 to 8bda0c4 Compare May 4, 2022 07:08
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch from 8bda0c4 to 25ed107 Compare May 4, 2022 07:20
@dkhokhlov dkhokhlov changed the title requests error handling [WIP] requests error handling May 9, 2022
@dkhokhlov dkhokhlov changed the title requests error handling fix: requests error handling May 9, 2022
@dkhokhlov dkhokhlov marked this pull request as ready for review May 9, 2022 06:24
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch from 4a5c80b to 2ecdcbe Compare May 9, 2022 06:40
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch 4 times, most recently from 858bc3e to ab1df06 Compare May 9, 2022 09:47
@dkhokhlov dkhokhlov requested a review from esatterwhite May 9, 2022 09:51
stsantilena
stsantilena reviewed May 9, 2022
View reviewed changes
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch from ab1df06 to 37d45dd Compare May 9, 2022 17:14
@dkhokhlov dkhokhlov requested a review from stsantilena May 9, 2022 17:15
@dkhokhlov dkhokhlov force-pushed the LOG-11814-error-handling branch from 37d45dd to bf9bf5c Compare May 9, 2022 17:25
stsantilena
stsantilena reviewed May 9, 2022
View reviewed changes
logdna/logdna.py
else:
reason = response.reason

if 200 < status_code <= 399:
Copy link

@stsantilena stsantilena May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So only 200 would be expected code?

Copy link
Contributor Author

@dkhokhlov dkhokhlov May 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, as successful, in this specific request.

stsantilena
stsantilena approved these changes May 9, 2022
View reviewed changes
Copy link

@stsantilena stsantilena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another small clarification. Other than that LGTM.

@dkhokhlov dkhokhlov merged commit e412859 into master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esatterwhite esatterwhite esatterwhite approved these changes

+1 more reviewer

@stsantilena stsantilena stsantilena approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkhokhlov @esatterwhite @stsantilena