Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG] Update the default advertised CSI version to csi version 1.2 #3079

@joshimoo

Description

@joshimoo

Describe the bug
Kubernetes >= v1.17 no longer supports csi version v0.3
We updated the components and the min kubernetes version but did not change the default advertised csi version

The relevant code needs to be changed here: https://github.com/longhorn/longhorn-manager/blob/0cf54c5c79dbc5b91a3bb31bad25fbd0ecd61b94/app/csi.go#L36

Environment:

  • Longhorn version: v1.1.3 and v1.2.x

Additional context
We should be safe to advertise at least https://github.com/container-storage-interface/spec/releases/tag/v1.2.0
There is some newer abilities in the newer versions that we are not yet taking advantage off.
We might want to implement ListVolumes which is used for attachment verification after the volume-controller refactor for v1.3

Metadata

Metadata

Labels

area/csiCSI related like control/node driver, sidecarsarea/install-uninstall-upgradeInstall, Uninstall or Upgrade relatedbackport/1.1.3Require to backport to 1.1.3 release branchbackport/1.2.1Require to backport to 1.2.1 release branchkind/bug

Type

No type

Projects

Status

Closed

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions