Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jklenzing
Copy link
Member

Description

Addresses #TBD

PyHC is testing out a common unit-test environment for core packages. This is currently accomplished by running the unit tests for a pip-installed version of pysat. While the tests are included as core code for use throughout the ecosystem, the test data some of the pysat-unique tests requires are not included here. This updates the manifest so that these files are included.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Created a clean virtual environment.
  • Created tar.gz via python -m build --sdist
  • Installed via pip in clean env directly from the tar.gz => pip install '../code/core/pysat/dist/pysat-3.2.2rc0.tar.gz[test]'
  • Ran tests via pytest --pyargs pysat.tests

Test Configuration:

  • Operating system: Sonoma 14.7.1
  • Version number: Python 3.12
  • Clean venv with install procedure above

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have linted the files updated in this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing marked this pull request as ready for review January 27, 2025 19:14
@jklenzing jklenzing requested a review from aburrell January 27, 2025 19:14
@jklenzing
Copy link
Member Author

@sapols, this should fix the issues from the PyHC meeting. Tested with a clean virtual environment. I will let you know when the eventual RC is up.

@sapols
Copy link

sapols commented Jan 28, 2025

Awesome. Thanks @jklenzing!

@jklenzing jklenzing merged commit 7aca3ea into develop Jan 29, 2025
28 of 31 checks passed
@jklenzing jklenzing deleted the bug/include_test_data branch January 29, 2025 14:07
@rstoneback
Copy link
Collaborator

Thanks @jklenzing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants