Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change max cost to include threshold #27

New issue
New issue
Closed
#90
Closed
Change max cost to include threshold#27
#90
@JamesSaxon

Description

@JamesSaxon
JamesSaxon
opened on Apr 3, 2022

This is a change was requested by @knaaptime in the discussion for 26. It is a one-character fix here:

access/access/fca.py

Line 55 in bfae8ed

if max_cost is not None: temp = temp[temp[cost_cost] < max_cost].copy()

But it will also break the expectations of the zero-catchment tests here:

access/access/tests/test_floating_catchment_area.py

Lines 75 to 80 in bfae8ed

def test_floating_catchment_area_ratio_zero_catchment(self):
zero_catchment = 0
result = self.model.fca_ratio(max_cost = zero_catchment)
actual = math.isnan(self.model.access_df.iloc[0]['fca_value'])
self.assertEqual(actual, True)

Not a hard change but your judgment call.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions