Replies: 6 comments
-
|
Thanks for bringing this up. I think this is related to issue #2539 by @fchapoton who has been looking into this in the past. |
Beta Was this translation helpful? Give feedback.
-
|
#2539 discusses using the linting feature of Ruff. I'm talking using the code formatting feature. |
Beta Was this translation helpful? Give feedback.
-
|
True! Ruff has been used in previous PRs to format code, e.g. #1922, #1902, #1903, #2108 (which was closed). |
Beta Was this translation helpful? Give feedback.
-
Those PRs are using the linting feature of ruff, which is the |
Beta Was this translation helpful? Give feedback.
-
The downsides shouldn't be a real issue, one can just add the commit that does the formatting to a |
Beta Was this translation helpful? Give feedback.
-
|
I'm generally against using a code formatter for this project. This can give developers more freedom and encourage them to focus on the scientific and physics aspects, than on formatting and style. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Using a code formatter like Ruff or Black improves the readability of the source code and makes the formatting more consistent. We're already using the Ruff lint check in CI, and we could also use Ruff to format the code. The downside is that formatting the entire code base would create a huge diff and mess up git blame.
I'm not sure if this idea has already been considered before. If so, feel free to close this issue.
Beta Was this translation helpful? Give feedback.
All reactions