Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ONNX] bump onnx submodule to rel-1.15.0 #110663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ONNX] bump onnx submodule to rel-1.15.0 #110663

wants to merge 2 commits into from

Conversation

@abock
Copy link
Contributor

@abock abock commented Oct 5, 2023 •
edited
Loading

  • onnx==1.15.0rc1
  • onnxscript==0.1.0.dev20231006
  • ort-nightly==1.17.0.dev20231005001

@abock abock requested a review from jeffdaily as a code owner October 5, 2023 22:43
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 5, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110663

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9f435d8 with merge base fb68aa0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 6, 2023
ezyang
ezyang requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel failures are legit

@abock
Copy link
Contributor Author

abock commented Oct 6, 2023

I suspect it might be related to this PR: onnx/onnx#5559

cc @liqunfu @gramalingam

@abock abock force-pushed the abock/onnx-1.15.0-validation branch 2 times, most recently from 50233ca to 87d9be8 Compare October 6, 2023 19:49
@abock
Copy link
Contributor Author

abock commented Oct 6, 2023

Looks like that was a new header and a glob for it was missing in the bazel build.

@ezyang
Copy link
Contributor

ezyang commented Oct 9, 2023

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased abock/onnx-1.15.0-validation onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout abock/onnx-1.15.0-validation && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the abock/onnx-1.15.0-validation branch from 87d9be8 to 600296c Compare October 9, 2023 16:55
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

abock added 2 commits October 10, 2023 15:45
@abock
[ONNX] bump onnx submodule to rel-1.15.0
f50a150 
- onnx==1.15.0rc1
- onnxscript==0.1.0.dev20231006
- ort-nightly==1.17.0.dev20231005001
@abock
[ONNX] use recursive glob for defs in bazel build
9f435d8
@abock abock force-pushed the abock/onnx-1.15.0-validation branch from 600296c to 9f435d8 Compare October 10, 2023 15:45
@abock abock added the module: onnx Related to torch.onnx label Oct 10, 2023
@ezyang
Copy link
Contributor

ezyang commented Oct 10, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the abock/onnx-1.15.0-validation branch April 11, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@thiagocrepaldi thiagocrepaldi thiagocrepaldi approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

ONNX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abock @ezyang @pytorchmergebot @thiagocrepaldi @pytorchbot