Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mfocko
Copy link
Member

@mfocko mfocko commented Aug 9, 2021

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm ;)

CHANGELOG.md Outdated
@@ -1,3 +1,10 @@
# 0.28.0

- Fixed bug with getting `conclusion` from GitHub's Check Run. (#618)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed bug with getting `conclusion` from GitHub's Check Run. (#618)
- Getting `conclusion` from GitHub's Check Run no longer raises an exception when it's not defined, it returns None instead now. (#618)

I find this text to be more informative

Signed-off-by: Matej Focko <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@mfocko
Copy link
Member Author

mfocko commented Aug 9, 2021

Issue coming from Sandcastle, merging manually, ACK'd by @TomasTomecek

@mfocko mfocko merged commit 50b71e1 into packit:main Aug 9, 2021
@mfocko mfocko deleted the release-0.28.0 branch August 9, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants