geocode: add support for openstreetmap geocoding api #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
approved these changes
May 17, 2022
yeah, I thought about that. We could always put a rate limiter on it 🤷🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the OpenStreetMap Nominatim API when no Google Geocoding API key is present. Nominatim does not require any keys, so we can safely enable it by default, though their terms request no more than 1 qps, which should probably be fine?
Docs and log messages are updated to reflect this behavior. OSM Attribution is added to the help page, which is not the best but probably okay for now. In a future change, I'd like to change the About alert to a static page, and move licensing information there.
Fixes #1342