Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fuse: misc fixes #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2022
Merged

fuse: misc fixes #1615

merged 1 commit into from
Jul 1, 2022

Conversation

@MichaHoffmann
Copy link
Member

@MichaHoffmann MichaHoffmann commented Jun 20, 2022 •
edited
Loading

This should fix some of the flakiness in the perkeep.org/pkg/fs tests.

  • propagate more context cancelations from pkg/client
  • convert ErrCancel to fuse.EINTR to enable clients to handle interrupts
  • improve interrupt handling in fs_test.go
  • fix race in mutdir between rename and first populate

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-fix-fuse-eintr branch 5 times, most recently from 7c9d1ef to 9b042b7 Compare June 21, 2022 21:57
bradfitz
bradfitz reviewed Jun 24, 2022
View reviewed changes
bradfitz
bradfitz reviewed Jun 24, 2022
View reviewed changes
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-fix-fuse-eintr branch 4 times, most recently from fa32823 to 1986dd7 Compare June 25, 2022 13:10
@MichaHoffmann
Copy link
Member Author

It might still happen that f.Close() gets interrupted; but test stability has greatly improved for me when testing it out since most interrupted syscalls seem to be retried in the stdlib.

@MichaHoffmann MichaHoffmann requested a review from bradfitz June 25, 2022 13:34
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-fix-fuse-eintr branch 2 times, most recently from afd2295 to 4ecaee0 Compare June 25, 2022 20:02
@MichaHoffmann MichaHoffmann changed the title fuse: improve eintr handling fuse: misc fixes Jun 25, 2022
@MichaHoffmann
fuse: misc fixes
1073c60 
* propagate more context cancelations from pkg/client
* convert ErrCancel to fuse.EINTR to enable clients to handle interrupts
* improve interrupt handling in fs_test.go
* fix race in mutDir between rename and first populate
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-fix-fuse-eintr branch from 4ecaee0 to 1073c60 Compare June 25, 2022 20:12
@bradfitz bradfitz merged commit 215de25 into perkeep:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradfitz bradfitz Awaiting requested review from bradfitz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaHoffmann @bradfitz