WIP: Remove pkg/index/sqlindex #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not used anywhere else in the codebase, and duplicates the functionality of pkg/sorted/sqlkv.
tgulacsi
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used anywhere else in the codebase, and duplicates the
functionality of pkg/sorted/sqlkv.
The only reference to it elsewhere is this comment:
perkeep/pkg/index/sqlite/sqlite_test.go
Line 173 in 39fde2e
...which seems to refer to a constant inside the package that doesn't exist. Probably the comment should be updated as part of this pr as well, but I don't fully understand what's going on in there so I'm not sure what to change it to.