encrypt.go: check keyFile permissions #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1c5fe4 to
69f8ed1
Compare
bradfitz
reviewed
Jan 11, 2021
pkg/blobserver/encrypt/encrypt.go
Outdated
| // TODO: check that keyFile's unix permissions aren't too permissive. | ||
| if fileInfo, err := os.Stat(keyFile); err != nil { | ||
| return nil, fmt.Errorf("Checking for key file permissions %v: %v", keyFile, err) | ||
| } else if fileInfo.Mode().Perm() != 0600 { |
There was a problem hiding this comment.
I think this might be too specific for Windows. You probably want Perm() & 0077 != 0 instead?
bradfitz
reviewed
Jan 11, 2021
| } | ||
|
|
||
| // Using key file | ||
| tmpKeyFile, _ := ioutil.TempFile(os.TempDir(), "camlitest") |
69f8ed1 to
64692cc
Compare
bradfitz
approved these changes
Jan 12, 2021
|
ping @bradfitz I still can't merge anything. Looks like I can manage issues but not push to protected branches. This is probably setup in repository permissions. Can you also add me to the org? Thanks |
Merged
Ah, indeed, we all the permissions set up all fancy here. I'd forgotten about that. All fixed. Try again? |
|
Works, thanks :) |
64692cc to
97e1bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picked-up a small todo in the code.