Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fs: don't cause io errors on missing blobrefs #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

fs: don't cause io errors on missing blobrefs #1377

merged 1 commit into from
Feb 1, 2021

Conversation

@aviau
Copy link
Member

@aviau aviau commented Jan 29, 2021 •
edited
Loading 

fs: don't cause io errors on missing blobrefs

- Looking up missing blobrefs would cause fs errors. Instead, simply
  return fuse.ENOENT.

- Add tests for:
   * validating that the mountpoint/<blobref> lookups work

   * validating that the mountpount/<blobref> lookups don't fail when
     the blob does not exist.

@googlebot googlebot added the cla: yes Author has submitted the Google CLA. label Jan 29, 2021
@aviau aviau force-pushed the aviau/test-root branch 2 times, most recently from fc2627a to ee78827 Compare January 29, 2021 05:34
@aviau aviau requested a review from bradfitz January 29, 2021 05:34
@aviau aviau added the needs review PRs that are ready to go, pending approval label Jan 29, 2021
@aviau
Copy link
Member Author

aviau commented Jan 29, 2021

cc @bradfitz for review!

@aviau aviau force-pushed the aviau/test-root branch 6 times, most recently from 22074dd to 60d0523 Compare February 1, 2021 02:15
@aviau aviau changed the title fs: don't cause ioerrors on notfound blobrefs fs: don't cause io errors on missing blobrefs Feb 1, 2021
@aviau
fs: don't cause io errors on missing blobrefs
9c61b9f 
- Looking up missing blobrefs would cause fs errors. Instead, simply
  return fuse.ENOENT.

- Add tests for:
   * validating that the mountpoint/<blobref> lookups work

   * validating that the mountpount/<blobref> lookups don't fail when
     the blob does not exist.
@aviau aviau merged commit 317e9f5 into master Feb 1, 2021
@aviau aviau deleted the aviau/test-root branch February 1, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradfitz bradfitz bradfitz approved these changes

Assignees

No one assigned

Labels

cla: yes Author has submitted the Google CLA. needs review PRs that are ready to go, pending approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aviau @bradfitz @googlebot